Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial import of "hat" #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ctron
Copy link

@ctron ctron commented Apr 3, 2020

No description provided.

@ctron ctron force-pushed the feature/add_hat_1 branch 2 times, most recently from 8d696f0 to 232444b Compare September 3, 2020 07:45
@ctron ctron marked this pull request as ready for review September 3, 2020 07:45
Copy link

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review any of the code (I don't speak Rust) ...
Does the tool already work with the Device Registry Management API or has it been developed against the original HTTP API?


Or by setting the environment variable `HAT_TENANT`:

HAT_TENANT=foo hat device create 4711

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be

HAT_TENANT=my-tenant

right?

<?define PlatformProgramFilesFolder = "ProgramFiles64Folder" ?>
<?define ProductUpgradeCode = "1b4094a4-2add-11e9-b676-c85b762e5a2c" ?>

</Include>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOL?

</Feature>

</Product>
</Wix>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOL?

@ctron
Copy link
Author

ctron commented Sep 11, 2020

I didn't review any of the code (I don't speak Rust) ...
Does the tool already work with the Device Registry Management API or has it been developed against the original HTTP API?

This works only with the new API.

@calohmn
Copy link
Contributor

calohmn commented Nov 18, 2020

@ctron Any updates regarding the comments above?

@@ -0,0 +1,167 @@
# HAT – Hono Admin Tool [![GitHub release](https://img.shields.io/github/release/ctron/hat.svg)](https://github.com/ctron/hat/releases)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better remove the image here? It refers and links to the ctron/hat repository (and the version number is 0.7.1, not the 0.7.2 defined here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants