Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building hono with profile run-tests depends on 127.0.0.1.nip.io #3183

Closed
boaks opened this issue Mar 30, 2022 · 1 comment · Fixed by #3186
Closed

Building hono with profile run-tests depends on 127.0.0.1.nip.io #3183

boaks opened this issue Mar 30, 2022 · 1 comment · Fixed by #3186
Assignees
@sophokles73
Labels
bug
Milestone
2.0.0

Comments

@boaks
Copy link
Contributor

boaks commented Mar 30, 2022

Building hono locally using the profile run-tests may currently fail, if 127.0.0.1.nip.iocould not be resolved.
That may be caused by DNS rebinding protection, especially, if executed in a home-network behind an internet router.

To support also builds without disable that protection, the test may be skipped, if 127.0.0.1.nip.io could not be resolved.
@boaks
Copy link
Contributor Author

boaks commented Mar 30, 2022

Using Ubuntu Resolve - 8.8.8.8 works as well, but removes the DNS rebinding protection.

I use an Ubuntu-derived distro with systemd-resolved resolver and the snippet below added to /etc/systemd/resolved.conf has permanently solved the issue:

[Resolve]
DNS=8.8.8.8
Domains=~nip.io

Needed to restart the service afterwards sudo service systemd-resolved restart
So all queries to nip.io are resolved by Google DNS, which apparently doesn't have the DNS rebind protection.

@sophokles73 sophokles73 added this to the 2.0.0 milestone Mar 30, 2022
@sophokles73 sophokles73 self-assigned this Mar 31, 2022
sophokles73 added a commit to bosch-io/hono that referenced this issue Mar 31, 2022
@sophokles73
[eclipse-hono#3183] Only run SNI ITs if DNS rebinding for nip.io is s…
8f3363f 
…upported

The integration tests verifying SNI based client authentication are now
run only if DNS rebinding for the nip.io domain works in the local
environment.

Fixes eclipse-hono#3183

Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
@sophokles73 sophokles73 mentioned this issue Mar 31, 2022
Merged
sophokles73 added a commit to bosch-io/hono that referenced this issue Apr 1, 2022
@sophokles73
[eclipse-hono#3183] Only run SNI ITs if DNS rebinding for nip.io is s…
667a9e4 
…upported

The integration tests verifying SNI based client authentication are now
run only if DNS rebinding for the nip.io domain works in the local
environment.

Fixes eclipse-hono#3183

Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
sophokles73 added a commit that referenced this issue Apr 1, 2022
@sophokles73
[#3183] Only run SNI ITs if DNS rebinding for nip.io is supported
9ab51b2 
The integration tests verifying SNI based client authentication are now
run only if DNS rebinding for the nip.io domain works in the local
environment.

Fixes #3183

Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophokles73 sophokles73

Labels
bug
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

[#3183] Only run SNI ITs if DNS rebinding for nip.io is supported bosch-io/hono
2 participants
@sophokles73 @boaks