[#3183] Only run SNI ITs if DNS rebinding for nip.io is supported #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boaks would you mind testing if this works in your environment? |
|
I will do so, but later this evening ... |
|
ROMM ("Runs On My Machine") |
|
LGTM |
…upported The integration tests verifying SNI based client authentication are now run only if DNS rebinding for the nip.io domain works in the local environment. Fixes eclipse-hono#3183 Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
sophokles73
force-pushed
the
run_sni_tests_conditionally
branch
from
8f3363f
to
667a9e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests verifying SNI based client authentication are now
run only if DNS rebinding for the nip.io domain works in the local
environment.
Fixes #3183