Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[#3656] Add Message Tracing logs" #3662

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

harism
Copy link
Contributor

@harism harism commented Oct 16, 2024

This reverts commit b94163d.

Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73
Copy link
Contributor

@harism During our conversation you were mentioning the standard Californium logging as being sufficient for your purposes. In my argument, though, I was referring to Hono's distributed tracing support, which I believe would be helpful in this case because it would not require correlating log files from different pods. However, I am not 100% sure, if the CoAP adapter currently creates a Span for messages on unsupported/unknown resource paths ...

@sophokles73 sophokles73 merged commit c110669 into eclipse-hono:master Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants