Added speed test. #421
Closed
Added speed test. #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterC-DLS
requested changes
Feb 3, 2020
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <classpath> | |||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.7"/> | |||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/> | |||
There was a problem hiding this comment.
Keep Java 8 changes to a separate PR
| <classpathentry kind="output" path="target/classes"/> | ||
| <classpathentry kind="var" path="M2_REPO/javax/measure/unit-api/1.0/unit-api-1.0.jar"/> | ||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/> | ||
| <classpathentry kind="lib" path="C:/Users/matt/.m2/repository/p2/osgi/bundle/javax.measure.unit-api/1.0.0.v20170818-1538/javax.measure.unit-api-1.0.0.v20170818-1538.jar"/> |
There was a problem hiding this comment.
Remove all your machine specific settings
| @@ -0,0 +1,117 @@ | |||
| package org.eclipse.january.dataset; | |||
There was a problem hiding this comment.
Place in a separate fragment and use JMH
| @@ -996,11 +996,11 @@ protected ILazyDataset createFromSerializable(Serializable blob, boolean keepLaz | |||
| if (is != 1 && is != getElementsPerItem()) { | |||
| throw new IllegalArgumentException("Dataset has incompatible number of elements with this dataset"); | |||
| } | |||
| d = ed.cast(is == 1 ? DoubleDataset.class: CompoundDoubleDataset.class); | |||
| d = ed.cast((Class<Dataset>)(is == 1 ? DoubleDataset.class: CompoundDoubleDataset.class)); | |||
There was a problem hiding this comment.
This is part of Java 8 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#420
First run of tests will fail until @ignore is added to test. This test is for future fixes or for developers to check changes in basic maths speed vs. a naive loop.