Refactor ASTRequestor to reduce the access it has to the compiler
#2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just my thought (though I probably won't have time to do a thorough review now) : If the only reason to pass in the compilation unit resolver is for creating bindings, and if clients may want to swap that out with something else, then this seems like a nice decoupling. Is it worth being more explicit (in the javadoc) on |
|
Good point, I'll make the Javadoc more specific |
This reduces the access that `ASTRequestor` has to the `CompilationUnitResolver` to just the method it needs, `createBinding`. This also makes it possible to use an alternate additional binding resolver instead of hardcoding the one implemented by `CompilationUnitResolver`. Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
simplify-additional-binding-interface
branch
from
f31c4ba
to
451b85f
Compare
|
@rgrunber Can you please re-review, and merge if everything is fine? |
|
As @rgrunber is on PTO, can @jjohnstn or @testforstephen you please have a look and merge if appropriate? |
testforstephen
approved these changes
Jul 3, 2024
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
…clipse-jdt#2637) This reduces the access that `ASTRequestor` has to the `CompilationUnitResolver` to just the method it needs, `createBinding`. This also makes it possible to use an alternate additional binding resolver instead of hardcoding the one implemented by `CompilationUnitResolver`. Signed-off-by: David Thompson <davthomp@redhat.com>
gayanper
pushed a commit
to gayanper/eclipse.jdt.core
that referenced
this pull request
Sep 7, 2024
…clipse-jdt#2637) This reduces the access that `ASTRequestor` has to the `CompilationUnitResolver` to just the method it needs, `createBinding`. This also makes it possible to use an alternate additional binding resolver instead of hardcoding the one implemented by `CompilationUnitResolver`. Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This reduces the access that
ASTRequestorhas to theCompilationUnitResolverto just the method it needs,createBinding.This also makes it possible to use an alternate additional binding resolver instead of hardcoding the one implemented by
CompilationUnitResolver.How to test
Run the AST Converter test suite (I'm sure this feature is used elsewhere, but this is the only place that I know uses it for sure).
Author checklist