Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload eventfile and unit test results #1389

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Upload eventfile and unit test results #1389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ on:
branches: '**'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one might also want to trigger this workflow on PRs...
See for example https://github.com/eclipse-platform/eclipse.platform.ui/blob/04265dec58c0fa26b5fe7360c0a6d56cf8218517/.github/workflows/ci.yml#L6-L10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one might also want to trigger this workflow on PRs...

In a previous discussion with @rgrunber , we agreed that we don't want it at the moment, to avoid the risk of disturbing current activity on JDT, and the failure here proves it was wise to be cautious.
We may discuss enabling it for PRs later if there is a demand for it from JDT contributors; but at the moment Jenkins seems sufficient and reliable enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If reporting problems is "disturbing" it might be better to delete verification checks altogether ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins does already report problems well enough. The ci.yml here is more added so that contributors can have GitHub builds on their forks for free, to validate their changes, before pushing a PR (that would then be verified on Jenkins).

Copy link
Contributor

@akurtakov akurtakov Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not upload test results from jenkins on pr as a comment?


jobs:
event_file:
name: "Upload Event File"
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: Event File
path: ${{ github.event_path }}
build:
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -35,3 +44,11 @@ jobs:
run: |
mvn clean install --batch-mode -f org.eclipse.jdt.core.compiler.batch -DlocalEcjVersion=99.99
mvn -U clean verify --batch-mode --fail-at-end -Ptest-on-javase-20 -Pbree-libs -Papi-check -Djava.io.tmpdir=$WORKSPACE/tmp -Dproject.build.sourceEncoding=UTF-8 -Dtycho.surefire.argLine="--add-modules ALL-SYSTEM -Dcompliance=1.8,11,17,20 -Djdt.performance.asserts=disabled" -Dcbi-ecj-version=99.99
- name: Upload Test Results for Linux
if: always()
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: test-results-linux
if-no-files-found: warn
path: |
${{ github.workspace }}/**/target/surefire-reports/*.xml
Loading