Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jclMin22.jar contains classes compiled against Java 21 #2912

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

iloveeclipse
Copy link
Member

Re-built jclMin22.jar from jclMin22src.jar with proper project compilation target and enabled test232816f().

Fixes #2580

@iloveeclipse
Copy link
Member Author

@laeubi : any idea where this is coming from:

ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.8:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.jdt.core.compiler.batch: Baseline and reactor have the same fully qualified version, but different content
18:40:45  [ERROR] different
18:40:45  [ERROR]    META-INF/ECLIPSE_.RSA: not present in baseline
18:40:45  [ERROR]    META-INF/ECLIPSE_.SF: not present in baseline

Does it mean, ecj is not signed in the 4.33?

@laeubi
Copy link
Contributor

laeubi commented Sep 5, 2024

According to the log the jar was replaced with the baseline so there should be no baseline diff. Maybe this needs a rebase on master now some settings have changed?

@iloveeclipse
Copy link
Member Author

According to the log the jar was replaced with the baseline so there should be no baseline diff. Maybe this needs a rebase on master now some settings have changed?

Isn't the error about different content between baseline and reactor? I'm sure this commit is on top of master.

@laeubi
Copy link
Contributor

laeubi commented Sep 5, 2024

Isn't the error about different content between baseline and reactor?

Yes but the logfile says that the main artifact (of the reactor) was replaced, what makes sense as you do not changed anything for ECJ (as far as I can see), so the error is really unexpected.

And thats also what the error complains, it says the jars have the exact same version but different contents...

While on this one https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Github/job/PR-2911/2/console

it complains that only qualifier changed (what usually indicates a missing version bump).

Re-built jclMin22.jar from jclMin22src.jar with proper project
compilation target and enabled test232816f().

Fixes eclipse-jdt#2580
@iloveeclipse iloveeclipse merged commit 365bc57 into eclipse-jdt:master Sep 5, 2024
9 checks passed
@iloveeclipse iloveeclipse deleted the issue_2580 branch September 5, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jclMin22.jar contains classes compiled against Java 21
2 participants