-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Remove obsolete build-scripts for ubunut-jikespg docker image #2993
Conversation
The history of those files points to https://bugs.eclipse.org/576415 The background is this: generating our parser from the grammar file Over time we had to fix a few bugs in that tool, as can be seen in https://github.com/jikespg/jikespg/tree/fixes-combined - Unfortunately, compiling this C program doesn't seem to be straight forward on windows machines. So when I change the grammar, I have no problem generating the parser (as I'm on linux), but @mpalat e.g. had issues with that. Ergo, Manoj will tell you, if the solution with parser-generator-as-a-service has been used recently. Look at the history of java.g to find out who changed the grammar file in the past. All of them needed to invoke jikespg one way or other. @srikanth-sankaran I believe you have a recent / functioning jikespg on your machine, right? |
I am on windows generally but use a Ubuntu VM for running jikespg. The parser generation service gave me some grief when I tried - don't remember the details. |
Thank you for your elaboration. But regardless of if the image is used or not the files suggested for removal with this PR are obsolete and not used anymore. |
I still use the RAW version and I don't use this service. I use an Ubuntu VM and then do the scp. However, script enabled people to onboard faster(especially if one is not familiar with UNIX world). That should stay. I will have to request the author of this setup, @sravanlakkimsetti to chime in here for an authoritative answer about deletion. |
I still use the job that's here - https://ci.eclipse.org/jdt/job/eclipse.jdt.core-jikespg-gerrit/ to run the parser generator. |
jikespg image was created for https://ci.eclipse.org/jdt/job/eclipse.jdt.core-jikespg-gerrit/ only. If this job is not being used anymore we can go ahead with the deletion. Since @jarthana confirmed that he is still using this job lets keep it. |
I'm closing this pull request in this case. |
It's good idea to update the dockerfile/image to supported Ubuntu version though. |
What it does
With eclipse-platform/eclipse.platform.releng.aggregator#2271 the removed scripts are not necessary anymore.
But in general I wonder if the build docker-image is even used at all? I could not find any references in the current build setup of JDT.
Unfortunately I also could not find the current number of recent pulls in Docker-Hub:
@akurtakov, @iloveeclipse, @jarthana or @sravanlakkimsetti could you help here or could tell who knows this?
Author checklist