[Build] Remove duplicated configuration of tycho-p2-extras-plugin #2994
Conversation
jukzi
force-pushed
the
remove-baseline-comparison-config
branch
from
6837e7f
to
d87fb8e
Compare
I am not an expert on this, so i have a basic question: Where is it configured that JDT uses eclipse-platform-parent? |
https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/pom.xml#L15 |
|
Can we hold this off? I'm about to work on an enhancement for this. |
HannesWell
force-pushed
the
remove-baseline-comparison-config
branch
from
d87fb8e
to
2ab7a15
Compare
|
Now it is ready, but requires eclipse-platform/eclipse.platform.releng.aggregator#2381 to succeed. |
Most parts of the configuration are already inherited from the 'eclipse-platform-parent'. And leverage the new overwritable property to permanently disable the baseline check, which is introduced in eclipse-platform/eclipse.platform.releng.aggregator#2381
akurtakov
force-pushed
the
remove-baseline-comparison-config
branch
from
2ab7a15
to
a580694
Compare
|
@akurtakov thanks for the update. The test-failure looks unrelated to me. |
What it does
Remove duplicated configuration of tycho-p2-extras-plugin. Most parts of the configuration are already inherited from the
eclipse-platform-parent:https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/73b7934ea89cbf0a8b0235572c8e80e84aed0104/eclipse-platform-parent/pom.xml#L372-L388
This would also help in the future in case JDT wants to use the workflow for automated version increments in pull-requests:
Also leverage the new overwritable property to permanently disable the baseline check, which is introduced in
@akurtakov, @iloveeclipse or @jukzi could you please have a look at this?
Author checklist