Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also handle RuntimeException when performing ClasspathFixProposal #1375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Apr 27, 2024

Currently when a RuntimeException occurs inside ClasspathFixProposal an obscure error dialog as the wizard already handles errors if they are InvocationTargetException this now wraps RuntimeException as well.

Currently when a RuntimeException occurs inside ClasspathFixProposal an
obscure error dialog as the wizard already handles errors if they are
InvocationTargetException this now wraps RuntimeException as well.
@@ -109,6 +109,8 @@ public static boolean openClasspathFixSelectionDialog(Shell parent, final IJavaP
throw new InterruptedException();
} catch (CoreException e2) {
throw new InvocationTargetException(e2);
} catch(RuntimeException e3) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but could we combine this with the upper catch block?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants