[23] JEP 467: Render markdown doc comments #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ dependency org.commonmark incl. extension for tables + new CoreMarkdownAccessImpl renders javadoc with markdown to HTML + skip insignificant whitespace assuming DOM contains all relevant whitespace fixes eclipse-jdt#1472
|
For this to work it needs eclipse-jdt/eclipse.jdt.core#2807 and possibly more. |
|
Test expectations are a bit complex where hyperlinks are involved. I confirmed manually in a runtime IDE that all links in test examples actually work as expected, except for #1579 - which is a bug also in traditional javadoc. |
+ test for code block at start and end of comment (bugs in javadoc tool) fixes eclipse-jdt#1472
This was referenced Aug 14, 2024
stephan-herrmann
added a commit
to stephan-herrmann/eclipse.jdt.ui
that referenced
this pull request
Aug 19, 2024
stephan-herrmann
added a commit
that referenced
this pull request
Aug 19, 2024
+ more tests along eclipse-jdt/eclipse.jdt.core#2831 fixes #1472
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1472