Implementation of #1251 create multiple types at once #1652
+1,774
−1,361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nettozahler please fix the build errors (you must not change existing API! You can add new API though), sign ECA and quash your commits to a single commit |
nettozahler
force-pushed
the
1251-create-multiple-types-at-once
branch
from
1c59008
to
7b12f4c
Compare
|
Fixed:
|
jukzi
reviewed
Sep 17, 2024
| @@ -758,14 +758,16 @@ private void internalSetJUnit4(boolean isJUnit4) { | |||
| } | |||
|
|
|||
| @Override | |||
| protected String constructCUContent(ICompilationUnit cu, String typeContent, String lineDelimiter) throws CoreException { | |||
There was a problem hiding this comment.
you must not change the Signature of methods that are API. or you get
The method org.eclipse.jdt.junit.wizards.NewTestSuiteWizardPage.constructCUContent(ICompilationUnit, String, String) has been removed
You can however add and additional method and make sure that the old API still works.
jukzi
reviewed
Sep 17, 2024
| @@ -3529,6 +3789,7 @@ public IStatus getSuperInterfaceStatus() { | |||
| } | |||
|
|
|||
| /** | |||
| * Getter. | |||
There was a problem hiding this comment.
Please avoid such Boiler plate comments and refactorings. they make this commit unnecessary complicated to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Implementation of #1251 (create multiple types at once)
How to test
TODO / open questions
Author checklist