migrate some junit 4 suites to junit 5 #1669
Conversation
|
@akurtakov can you have a look if this is what you suggested? |
carstenartur
force-pushed
the
migratejunit5suite
branch
from
813f0dd
to
6eb4dc7
Compare
|
I haven't done detailed review but this is aligning with the overall idea - make suites JUnit5 ones so individual tests can be added/migrated to JUnit 5 later. |
| @@ -124,6 +126,12 @@ public static void setUpTest() { | |||
| public void setUp() throws Exception { | |||
| fProject= pts.getProject(); | |||
|
|
|||
| Map<String, String> options= fProject.getOptions(false); | |||
There was a problem hiding this comment.
Is this on purpose here? This hardcoded 1.8 compliance here doesn't seem correct to me.
There was a problem hiding this comment.
It was in despair because of the build issues. Can be removed.
There was a problem hiding this comment.
Just wanted to delete the file from the patch. In gerrit it was possible. Hmm, should stay away from this while accessing it from a mobile phone. Sorry
|
Same number of tests, tests succeed, only a small portion of new code which looks wrong to me. |
…/FatJarExportTests.java Delete accidently changed file
| @@ -1,1017 +0,0 @@ | |||
| /******************************************************************************* | |||
There was a problem hiding this comment.
You should have deleted your change only, not the whole file.
|
Hi @akurtakov I did look at it and was waiting for your comments as @carstenartur was asking if it met your expectations. I too noticed that same number of tests ran and succeeded. Does this patch make it possible to have the explicit encoding tests added instead of forcing manual execution? |
What it does
As suggested in #1631 (comment) here we have a first try to update the suites from junit 4 to junit 5 so that step by step upgrade of tests to junit 5 or even a mix of junit 4 and junit 5 based tests is possible.
Unfortunately there are two issues currently:
How to test
Author checklist