feat: add file upload size limit with friendly error messages #366

SpursJiang · 2025-09-14T02:44:34Z

Add file upload size validation with user-friendly error messages
Implement HandshakeController to communicate size limits to frontend
Add GlobalExceptionHandler for handling file size exceeded errors
Update FileTransferForm to show clear size limit warnings
Add bilingual documentation for file upload configuration
Support both English and Chinese error messages

- Add file upload size validation with user-friendly error messages - Implement HandshakeController to communicate size limits to frontend - Add GlobalExceptionHandler for handling file size exceeded errors - Update FileTransferForm to show clear size limit warnings - Add bilingual documentation for file upload configuration - Support both English and Chinese error messages Signed-off-by: jiangpeng <949474720@qq.com>

- Fix test compatibility issue by making MultipartProperties parameter optional - Add null check to prevent NullPointerException in test environments - Ensure file size limit feature works when MultipartProperties is available Signed-off-by: spursjiang <949474720@qq.com>

Copilot

Pull Request Overview

This PR implements configurable file upload size limits with comprehensive user experience improvements. It adds dynamic size validation, friendly error messages in both English and Chinese, and seamless communication between backend configuration and frontend interface.

Dynamic file size limit configuration retrieved from backend via handshake API
Comprehensive file upload error handling with size-specific messages
Frontend validation with immediate feedback and bilingual support

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
site/docs/zh/guide/file-upload-configuration.md	New comprehensive Chinese documentation for file upload configuration
site/docs/zh/guide/configuration.md	Added Chinese documentation for multipart configuration properties
site/docs/guide/file-upload-configuration.md	New comprehensive English documentation for file upload configuration
site/docs/guide/configuration.md	Added English documentation for multipart configuration properties
site/docs/guide/changelog.md	Updated changelog with file upload enhancement features
server/src/main/java/org/eclipse/jifa/server/util/ErrorUtil.java	Added utility method for creating structured error responses
server/src/main/java/org/eclipse/jifa/server/enums/ServerErrorCode.java	Added FILE_TOO_LARGE error code for file size violations
server/src/main/java/org/eclipse/jifa/server/domain/dto/HandshakeResponse.java	Extended handshake response to include maximum file size configuration
server/src/main/java/org/eclipse/jifa/server/controller/HandshakeController.java	Enhanced controller to communicate file size limits to frontend
server/src/main/java/org/eclipse/jifa/server/controller/GlobalExceptionHandler.java	Added comprehensive file upload size exception handling
frontend/src/stores/env.ts	Added file size limit storage and management in environment store
frontend/src/i18n/zh.ts	Added Chinese translations for file upload messages
frontend/src/i18n/en.ts	Added English translations for file upload messages
frontend/src/components/forms/FileTransferForm.vue	Enhanced upload form with size validation and error handling
analysis/gc-log/src/test/java/org/eclipse/jifa/gclog/TestFragmentedParserToMetrics.java	Fixed comma placement in printf statement
analysis/gc-log/src/main/java/org/eclipse/jifa/gclog/parser/AbstractPreUnifiedGCLogParser.java	Fixed parenthesis character in comment

Files not reviewed (1)

frontend/package-lock.json: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

server/src/main/java/org/eclipse/jifa/server/controller/HandshakeController.java

server/src/main/java/org/eclipse/jifa/server/controller/GlobalExceptionHandler.java

frontend/src/components/forms/FileTransferForm.vue

D-D-H · 2025-09-15T09:34:45Z

eca has passed.

- Fix null MultipartProperties handling in HandshakeController - Simplify fragile string parsing in GlobalExceptionHandler - Improve error.response type safety in FileTransferForm

SpursJiang · 2025-09-16T05:16:11Z

Thanks for the suggestions! I've addressed all issues。

SpursJiang · 2025-09-17T13:42:35Z

Could you please merge my pull request?

D-D-H · 2025-09-25T11:32:22Z

frontend/src/components/forms/FileTransferForm.vue

+}
+
+// Format file size
+function formatFileSize(bytes) {


I think we can reuse the simmilar function in

jifa/frontend/src/support/utils.ts

Line 21 in 287dfb8

export function prettySize(size: number): string {

D-D-H · 2025-09-25T11:35:34Z

frontend/src/stores/env.ts


-    disabledFileTransferMethods: []
+    disabledFileTransferMethods: [],
+    maxFileSize: 536870912 // Default 512MB


Unlimited size for the default may be a better choice.

D-D-H · 2025-09-25T11:36:24Z

frontend/src/support/utils.ts

 import {formatDate} from '@vueuse/core';
 import {ElNotification} from 'element-plus';
 import {h} from 'vue';
+import { useI18n } from 'vue-i18n';


imported but not used?

D-D-H · 2025-09-25T11:37:00Z

server/src/main/java/org/eclipse/jifa/server/Constant.java

+    /**
+     * Default maximum file size limit (512MB) - matches Spring Boot's default
+     */
+    long DEFAULT_MAX_FILE_SIZE_BYTES = 512L * 1024L * 1024L;


Unlimited size for the default may be a better choice.

D-D-H · 2025-09-25T11:37:12Z

server/src/main/java/org/eclipse/jifa/server/controller/GlobalExceptionHandler.java

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (c) 2023 Contributors to the Eclipse Foundation
+ * Copyright (c) 2023, 2024 Contributors to the Eclipse Foundation


2024 -> 2025

D-D-H · 2025-09-25T11:39:05Z

server/src/main/java/org/eclipse/jifa/server/controller/GlobalExceptionHandler.java

+        int exp = (int) (Math.log(bytes) / Math.log(1024));
+        String pre = "KMGTPE".charAt(exp - 1) + "";
+        return String.format("%.1f %sB", bytes / Math.pow(1024, exp), pre);
+    }


I'm not sure if we already have a similar method in our Java code.

D-D-H · 2025-09-25T11:39:57Z

server/src/main/java/org/eclipse/jifa/server/controller/GlobalExceptionHandler.java

+    /**
+     * Handle file upload size exceeded exceptions with simple, reliable error message
+     */
+    private void handleFileUploadSizeExceeded(MaxUploadSizeExceededException e, HttpServletResponse response) throws IOException {


Why do we need to handle this exception especially?

What this achieves:
Automatic interception: When Spring MVC throws MaxUploadSizeExceededException, our handler catches it immediately
User-friendly response: Returns a structured error with FILE_TOO_LARGE error code and formatted file size
Frontend integration: Provides the exact data needed for frontend internationalization
Proper HTTP status: Returns 413 (Payload Too Large) status code following HTTP standards
Logging for debugging: Captures detailed information for troubleshooting while keeping user-facing messages clean

D-D-H · 2025-09-25T11:45:28Z

server/src/main/java/org/eclipse/jifa/server/controller/HandshakeController.java

                                     config.getDisabledFileTransferMethods(),
-                                     user);
+                                     user,
+                                     maxFileSizeBytes);


If maxFileSizeBytes only limits the files uploaded through web pages, I think we should use a more appropriate name, like maxUploadSize.

D-D-H · 2025-09-25T11:46:42Z

server/src/main/java/org/eclipse/jifa/server/util/ErrorUtil.java

        return json.toString().getBytes(Constant.CHARSET);
    }

+    public static byte[] toJson(ErrorCode errorCode, String message) {


Why don't we reuse the method: public static byte[] toJson(Throwable throwable).

D-D-H · 2025-09-25T11:47:42Z

@SpursJiang

Hi, sorry for the late response.

I left some comments for this patch.

Thanks for the contribution.

…back - Remove duplicate formatFileSize function, reuse existing prettySize utility - Use unlimited size as default instead of hardcoded 512MB limit - Update copyright year to 2025 in GlobalExceptionHandler - Replace custom formatFileSize with Apache Commons FileUtils.byteCountToDisplaySize - Rename maxFileSizeBytes to maxUploadSize for better clarity - Refactor ErrorUtil.toJson to eliminate code duplication with shared buildJsonBytes method - Simplify file upload error handling logic to use 200 status code - Remove unused imports and clean up code structure - Ensure consistent configuration logic between HandshakeController and GlobalExceptionHandler

SpursJiang · 2025-09-29T15:07:19Z

Thanks for the suggestions! I've addressed all issues。Could you please merge my pull request?

@SpursJiang

Hi, sorry for the late response.

I left some comments for this patch.

Thanks for the contribution.

Thanks for the suggestions! I've addressed all issues。Could you please merge my pull request?

SpursJiang mentioned this pull request Sep 14, 2025

ECA validation failed for PR #366 despite having signed ECA #367

Closed

D-D-H requested review from D-D-H and Copilot and removed request for D-D-H September 15, 2025 09:31

Copilot AI reviewed Sep 15, 2025

View reviewed changes

D-D-H closed this Sep 15, 2025

D-D-H reopened this Sep 15, 2025

fix: address GitHub Copilot suggestions for file upload handling

9c012bd

- Fix null MultipartProperties handling in HandshakeController - Simplify fragile string parsing in GlobalExceptionHandler - Improve error.response type safety in FileTransferForm

D-D-H reviewed Sep 25, 2025

View reviewed changes

feat: add file upload size limit with friendly error messages #366

Are you sure you want to change the base?

feat: add file upload size limit with friendly error messages #366

Uh oh!

Conversation

SpursJiang commented Sep 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

D-D-H commented Sep 15, 2025

Uh oh!

SpursJiang commented Sep 16, 2025

Uh oh!

SpursJiang commented Sep 17, 2025

Uh oh!

D-D-H Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

D-D-H commented Sep 25, 2025

Uh oh!

SpursJiang commented Sep 29, 2025

Uh oh!

Uh oh!

D-D-H Sep 25, 2025 •

edited

Loading