fix (jkube-kit) : JKubeTarArchiver should always set set TarEntry size to zero for directories (#777) #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1631 (2022-07-12T06:44:47Z) ⚙️ JKube E2E Tests (2654393335)
|
Codecov Report
@@ Coverage Diff @@
## master #1631 +/- ##
============================================
+ Coverage 51.92% 51.93% +0.01%
- Complexity 3862 3864 +2
============================================
Files 460 460
Lines 20722 20723 +1
Branches 2818 2819 +1
============================================
+ Hits 10759 10762 +3
+ Misses 8849 8848 -1
+ Partials 1114 1113 -1
Continue to review full report at Codecov.
|
…e to zero for directories (eclipse-jkube#777) While fixing tarball issue in eclipse-jkube#793, we had added this `tarEntry.setSize(0L)` in JKubeTarArchiver to fix tarball compatibility with old docker daemons. However, it is set only when the file is not present in `fileModeMap`. In case of Dockerfile based builds, `fileModeMap` seems to contain file modes for different files and directories. Hence, we're not able to set TarEntry size to zero. Move `tarEntry.setSize(0L)` out of fileMode related `if-else` block.
rohanKanojia
force-pushed
the
pr/issue777-followup
branch
from
cf9a71b to
845a611
Compare
|
Kudos, SonarCloud Quality Gate passed! |
manusa
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #777
While fixing tarball issue in #793, we had added this
tarEntry.setSize(0L)in JKubeTarArchiver to fix tarball compatibilitywith old docker daemons. However, it is set only when the file is not
present in
fileModeMap.In case of Dockerfile based builds,
fileModeMapseems to contain filemodes for different files and directories. Hence, we're not able to set
TarEntry size to zero.
Move
tarEntry.setSize(0L)out of fileMode relatedif-elseblock.Fixes # (issue)
Type of change
test, version modification, documentation, etc.)
Checklist