Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to configure secure connection client certificate #10

Closed
gkoitchev-bosch opened this issue Aug 5, 2022 · 1 comment · Fixed by #11
Closed

Add flags to configure secure connection client certificate #10

gkoitchev-bosch opened this issue Aug 5, 2022 · 1 comment · Fixed by #11
Assignees
@gboyvalenkov-bosch
Labels
security Security improvement task Single unit of work
Milestone
M2

Comments

@gkoitchev-bosch
Copy link
Contributor

After filtering out the insecure connections with HTTPS scheme, we need to have option to configure loading client certificate from file.
So, everywhere, where client certificate is mentioned, there are added parameters for the certificate and the key.
Currently, the system pool is used.
gkoitchev-bosch added a commit to bosch-io/software-update that referenced this issue Aug 5, 2022
@gkoitchev-bosch
[eclipse-kanto#10] Add flags to configure secure connection client ce…
e819884 
…rtificate

There should be an option to configure loading client certificate from file, instead of using the system pool.

Signed-off-by: Georgi Koitchev <georgi.koitchev@bosch.io>
@gkoitchev-bosch gkoitchev-bosch mentioned this issue Aug 5, 2022
Merged
@e-grigorov e-grigorov linked a pull request Aug 7, 2022 that will close this issue
Add flags to configure secure connection client certificate #11
Merged
@e-grigorov e-grigorov added the task Single unit of work label Aug 7, 2022
@e-grigorov e-grigorov moved this to In Review in Eclipse Kanto Aug 7, 2022
@e-grigorov e-grigorov added this to the M2 milestone Aug 7, 2022
@e-grigorov
Copy link
Contributor

What is the scope of this task i.e. is it only about the download operation or it'll cover some other connections? If the scope is only the download, I would like to suggest to clarify the description. Currently:

  • download is not mentioned in the title/description
  • "after filtering out the insecure connections with HTTPS scheme" - what is the task behind this?
  • "everywhere, where client certificate is mentioned" - the task description doesn't need to have implementation details but we have to be more concrete about the use case. Just "everywhere" doesn't provide useful information.

gkoitchev-bosch added a commit to bosch-io/software-update that referenced this issue Aug 12, 2022
@gkoitchev-bosch
[eclipse-kanto#10] Add flags to configure secure connection client ce…
5c2c9ad 
…rtificate

There should be an option to configure loading client certificate from file, instead of using the system pool.
- Added flags
- Added parameters for cert and key files where secure connection is established.

Signed-off-by: Georgi Koitchev <georgi.koitchev@bosch.io>
gboyvalenkov-bosch added a commit to bosch-io/software-update that referenced this issue Aug 15, 2022
@gboyvalenkov-bosch
[eclipse-kanto#10] Add flags to configure secure connection client ce…
89b70f2 
…rtificate

- removed key flag
- cert flag renamed to serverCert
- removed license files

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
gboyvalenkov-bosch added a commit to bosch-io/software-update that referenced this issue Aug 16, 2022
@gboyvalenkov-bosch
[eclipse-kanto#10] Add flags to configure secure connection client ce…
5ac3e31 
…rtificate

- removed secure cipher suites from tls config, as it is part of another issue

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
gboyvalenkov-bosch added a commit to bosch-io/software-update that referenced this issue Aug 16, 2022
@gboyvalenkov-bosch
[eclipse-kanto#10] Add flags to configure secure connection client ce…
1b97065 
…rtificate

- unified implementations of http test servers
- minor refactoring and improvements

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
gboyvalenkov-bosch added a commit to bosch-io/software-update that referenced this issue Aug 17, 2022
@gboyvalenkov-bosch
[eclipse-kanto#10] Add flags to configure secure connection client ce…
d1d0327 
…rtificate

- implementation only

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
@e-grigorov e-grigorov mentioned this issue Aug 17, 2022
Closed
gboyvalenkov-bosch added a commit to bosch-io/software-update that referenced this issue Aug 17, 2022
@gboyvalenkov-bosch
[eclipse-kanto#10] Add flags to configure secure connection client ce…
19699ba 
…rtificate

- minor description/default value adjustments

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
gboyvalenkov-bosch added a commit to bosch-io/software-update that referenced this issue Aug 17, 2022
@gboyvalenkov-bosch
[eclipse-kanto#10] Add flags to configure secure connection client ce…
9f274bc 
…rtificate

- minor description adjustments

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
e-grigorov pushed a commit that referenced this issue Aug 18, 2022
@gkoitchev-bosch
Add flags to configure secure connection client certificate (#11)
ef98a29 
[#10] Add flags to configure secure connection client certificate

There should be an option to configure loading client certificate from file, instead of using the system pool.

Signed-off-by: Georgi Koitchev <georgi.koitchev@bosch.io>

- removed key flag
- cert flag renamed to serverCert
- removed license files
- removed secure cipher suites from tls config, as it is part of another issue
- unified implementations of http test servers

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
Repository owner moved this from In Review to Done in Eclipse Kanto Aug 18, 2022
@e-grigorov e-grigorov added the security Security improvement label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gboyvalenkov-bosch gboyvalenkov-bosch

Labels
security Security improvement task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M2
Development

Successfully merging a pull request may close this issue.

Add flags to configure secure connection client certificate bosch-io/software-update
3 participants
@e-grigorov @gboyvalenkov-bosch @gkoitchev-bosch