Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to configure secure connection client certificate #11

Merged
merged 8 commits into from
Aug 18, 2022

Conversation

gkoitchev-bosch
Copy link
Contributor

[#10] Add flags to configure secure connection client certificate

There should be an option to configure loading client certificate from file, instead of using the system pool.

Signed-off-by: Georgi Koitchev georgi.koitchev@bosch.io

…rtificate

There should be an option to configure loading client certificate from file, instead of using the system pool.

Signed-off-by: Georgi Koitchev <georgi.koitchev@bosch.io>
@e-grigorov e-grigorov linked an issue Aug 7, 2022 that may be closed by this pull request
internal/flags.go Outdated Show resolved Hide resolved
…rtificate

There should be an option to configure loading client certificate from file, instead of using the system pool.
- Added flags
- Added parameters for cert and key files where secure connection is established.

Signed-off-by: Georgi Koitchev <georgi.koitchev@bosch.io>
internal/flags.go Outdated Show resolved Hide resolved
internal/flags.go Outdated Show resolved Hide resolved
internal/flags_test.go Outdated Show resolved Hide resolved
internal/flags_test.go Outdated Show resolved Hide resolved
internal/flags_test.go Outdated Show resolved Hide resolved
licenses/LICENSE.google_uuid-1.3.0 Outdated Show resolved Hide resolved
licenses/LICENSE.gorilla_websocket-1.4.2 Outdated Show resolved Hide resolved
licenses/LICENSE.natefinch_lumberjack.v2-2.0.0 Outdated Show resolved Hide resolved
internal/utils_test.go Outdated Show resolved Hide resolved
…rtificate

- removed key flag
- cert flag renamed to serverCert
- removed license files

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
…rtificate

- removed secure cipher suites from tls config, as it is part of another issue

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
internal/storage/download_test.go Outdated Show resolved Hide resolved
internal/storage/download_test.go Outdated Show resolved Hide resolved
internal/storage/download_test.go Outdated Show resolved Hide resolved
internal/storage/testdata/valid_key.pem Outdated Show resolved Hide resolved
internal/flags.go Show resolved Hide resolved
internal/flags_test.go Outdated Show resolved Hide resolved
internal/storage/download_test.go Outdated Show resolved Hide resolved
internal/storage/download_test.go Outdated Show resolved Hide resolved
…rtificate

- unified implementations of http test servers
- minor refactoring and improvements

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
…rtificate

- implementation only

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
internal/flags.go Outdated Show resolved Hide resolved
internal/flags.go Show resolved Hide resolved
internal/storage/download.go Outdated Show resolved Hide resolved
…rtificate

- minor description/default value adjustments

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
…rtificate

- minor description adjustments

Signed-off-by: Georgi Boyvalenkov <Georgi.Boyvalenkov@bosch.io>
@e-grigorov e-grigorov merged commit ef98a29 into eclipse-kanto:main Aug 18, 2022
@e-grigorov e-grigorov deleted the flags_secure_connection branch August 18, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flags to configure secure connection client certificate
3 participants