Fix flakey SDK test cases #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrylo
requested changes
Mar 18, 2024
...rc/test/kotlin/org/eclipse/kuksa/connectivity/databroker/docker/DockerDatabrokerContainer.kt
Outdated
Show resolved
Hide resolved
...rc/test/kotlin/org/eclipse/kuksa/connectivity/databroker/docker/DockerDatabrokerContainer.kt
Outdated
Show resolved
Hide resolved
...rc/test/kotlin/org/eclipse/kuksa/connectivity/databroker/docker/DockerDatabrokerContainer.kt
Outdated
Show resolved
Hide resolved
...kotlin/org/eclipse/kuksa/connectivity/databroker/docker/DockerInsecureDatabrokerContainer.kt
Outdated
Show resolved
Hide resolved
...t/kotlin/org/eclipse/kuksa/connectivity/databroker/docker/DockerSecureDatabrokerContainer.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #85
Closes: #97
The DockerDatabrokerContainer was introduced which uses java-docker to spawn / shutdown instances of the Databroker. Two different implementations are avilable SecureDockerDatabrokerContainer (auth enabled, tls enabled) and InsecureDockerDatabrokerContainer (auth disabled, tls disabled). I removed the "Authentication"-flavor which was basically "auth enabled, no tls".
A separate instance of the Databroker is now used for testDebugUnitTest and testReleaseUnitTest. This should reduce the clashes when running the same test at the same time.
I also rewrote most of the tests to use the Friendly*Listener and tried to generalize the tests more so that we no longer wait until x results are available (before: subscribe -> wait until one result is available -> check assumptions; now: subscribe -> check more generic assumptions which identify our operation succeded)
Since the different Databroker Instances are spawned by Android it is no longer required to start a Databroker instance before hand, so that the tests are running fine. It is also no longer required to start different flavor of Databrokers (e.g. tls enabled, auth enabled, insecure mode,...).
What still won't work reliably is when multiple terminals execute tests at the same time because one testset might spawn a SecureDatabroker while the other one tests on a InsecureDatabroker.