Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown/unknown #13

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

erikbosch
Copy link
Contributor

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikbosch
Copy link
Contributor Author

eclipse-kuksa/kuksa-python-sdk#22 (review) same discussion as here.

Result with PR, we build for "all" architectures regardless of whether you have "secret" or not.

rik@debian4:~/kuksa-gps-provider$ docker manifest inspect ttl.sh/eclipse-kuksa/kuksa-can-provider/can-provider-cc99daac5a32efa233f6dededfda13d104f8a923
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3630,
         "digest": "sha256:9579d512a0ab229c3c4175b3c67cdca0ec831e27c9cc2a5646e8d0fc37f42dd9",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3630,
         "digest": "sha256:9c5a7ee50fdb83f2a7034d99df54d2298f9c259716e1734419798f46edcaa68b",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      }
   ]
}

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikbosch erikbosch merged commit 56ae77d into eclipse-kuksa:main Mar 19, 2024
7 checks passed
@erikbosch erikbosch deleted the erik_github branch March 19, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants