Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cand_fd parameter #35

Merged

Conversation

phonglv3-fa
Copy link
Contributor

Fixes #33
Use parameter name "fd" when initializing CANClient

@SebastianSchildt
Copy link
Contributor

Hi, thanks for the fix. We can only merge it you have an Eclipse account and "sign" the ECA, that basically, that means

  • Create anEclipse account and sign the ECA, see https://www.eclipse.org/legal/ecafaq.php.
  • Then your e-mail address specified in Git commit must match that of your eclipse account (it may also be enough tell the Eclipse backend your Github Username phonglv3-fa in the Eclipse accounts "Edit profile" page

@phonglv3-fa
Copy link
Contributor Author

Thanks for letting me know, @SebastianSchildt.
I have created Eclipse account and signed the ECA. I hope you approve the merge.

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the fix!

lgtm 🍏

@SebastianSchildt SebastianSchildt merged commit 669bb12 into eclipse-kuksa:main Jan 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent CAN FD parameter name
2 participants