Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A build workflow for the Release-With-Debug profile #126

Merged
merged 8 commits into from
Feb 6, 2025

Conversation

mikehaller
Copy link
Contributor

Note: This PR is part of cleaning up #113 which got mixed up with devcontainer setup and more changes.

A build workflow for the release-with-debug profile, which creates a databroker binary with debug symbols enabled.
This is useful for the integration into an eBPF-based performance test environments.

As separate testers would need to rebuild databroker with that profile, which requires them to set up their own databroker development environment, we've decided for convenience to release debug versions of databroker for exactly that use case.

The additional debugsymbols.txt file in the archive contains the entry point for eBPF probes to instrument the function within databroker where the VSS Signals are being updated by providers:

DatabaseWriteAccess.update()

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.14%. Comparing base (6459879) to head (880861e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   60.14%   60.14%           
=======================================
  Files          33       33           
  Lines       16191    16191           
=======================================
  Hits         9738     9738           
  Misses       6453     6453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Only the question about the updated Cargo.lock arises again :) Should we update this in this PR?

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmittag lukasmittag merged commit 9773043 into eclipse-kuksa:main Feb 6, 2025
35 checks passed
@mikehaller mikehaller deleted the debugprofile branch February 6, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants