-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A build workflow for the Release-With-Debug profile #126
A build workflow for the Release-With-Debug profile #126
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 60.14% 60.14%
=======================================
Files 33 33
Lines 16191 16191
=======================================
Hits 9738 9738
Misses 6453 6453 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Only the question about the updated Cargo.lock
arises again :) Should we update this in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: This PR is part of cleaning up #113 which got mixed up with devcontainer setup and more changes.
A build workflow for the
release-with-debug
profile, which creates a databroker binary with debug symbols enabled.This is useful for the integration into an eBPF-based performance test environments.
As separate testers would need to rebuild databroker with that profile, which requires them to set up their own databroker development environment, we've decided for convenience to release debug versions of databroker for exactly that use case.
The additional
debugsymbols.txt
file in the archive contains the entry point for eBPF probes to instrument the function within databroker where the VSS Signals are being updated by providers: