Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial example for testing slow subscribers #127

Merged

Conversation

mikehaller
Copy link
Contributor

The example shows a subscriber which is intentionally slow in receiving updates.

When running in parallel with kuksa-perf, there are too many updates of the signal which the slow subscriber will not be able to keep up with and will start throwing away signal updates. When this happens, the channel on the databroker side will log a warning message and indicate how many signal updates were lost for the slow subscriber.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.10%. Comparing base (9773043) to head (43694c7).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/broker.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   60.11%   60.10%   -0.01%     
==========================================
  Files          33       33              
  Lines       16191    16192       +1     
==========================================
  Hits         9733     9733              
- Misses       6458     6459       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only problem again the high level Cargo.lock that is updated the one under lib shall be kept.

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmittag lukasmittag merged commit d7f8a36 into eclipse-kuksa:main Feb 6, 2025
34 checks passed
@mikehaller mikehaller deleted the slowperformer branch February 6, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants