Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Commit hook for cargo fmt and clippy #135

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mikehaller
Copy link
Contributor

To prevent checks on GitHub PullRequests to fail due to formatting and linting errors (which also may be introduced or changed by updated cargo versions), they are added to the pre-commit hook by this PR.

Did not add any other cargo build, compile or test steps, as these are much more expensive and would increase the wait time for commits unnecessarily.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.14%. Comparing base (9773043) to head (3d3a72a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   60.11%   60.14%   +0.03%     
==========================================
  Files          33       33              
  Lines       16191    16191              
==========================================
+ Hits         9733     9738       +5     
+ Misses       6458     6453       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants