Disable sdv.databroker.v1 by default #20
Conversation
argerus
commented
Apr 24, 2024
argerus
commented
- Disable sdv.databroker.v1 by default. It can be enabled by supplying a flag at startup.
- Change databroker-cli to use kuksa.val.v1 by default.
| ( | ||
| "subscribe", | ||
| "<QUERY>", | ||
| "Subscribe to signals with QUERY, if you use kuksa feature comma separated list", | ||
| ), | ||
| ("feed", "<PATH> <VALUE>", "Publish signal value"), | ||
| ("publish", "<PATH> <VALUE>", "Publish signal value"), |
There was a problem hiding this comment.
Yes, that crossed my mind as well. I'm not against it, but my idea is that publish is that act of publishing a single signal value, while "provide" might be better suited for describing the act of continuously providing a signal. "publish" would then be the logical counterpart to "subscribe".
I suppose we will have a discussion around this in the API design rounds. I just couldn't stand having feed still there 🥲
| @@ -42,7 +42,7 @@ const CLI_COMMANDS: &[(&str, &str, &str)] = &[ | |||
| "<QUERY>", | |||
| "Subscribe to signals with QUERY, if you use kuksa feature comma separated list", | |||
| ), | |||
| ("feed", "<PATH> <VALUE>", "Publish signal value"), | |||
| ("publish", "<PATH> <VALUE>", "Publish signal value"), | |||
| .add_service( | ||
| let kuksa_val_v1 = { | ||
| if apis.contains(&Api::KuksaValV1) { | ||
| Some(kuksa::val::v1::val_server::ValServer::with_interceptor( |
There was a problem hiding this comment.
val_server can maybe cause confusion with old kuksa_val_server in c++?
There was a problem hiding this comment.
This was not changed as part of this commit. It is referencing generated code, which having a protobuf service definition like this:
service VAL {
...
}will generate code <snake case service name>_server::<camel case service name>Server, i.e. val_server::ValServer.
- Disable sdv.databroker.v1 by default. It can be enabled by supplying a flag at startup. - Change databroker-cli to use kuksa.val.v1 by default.
argerus
force-pushed
the
feature/disable_sdv
branch
from
35035df to
9f7ec57
Compare
