Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Databroker submodule and Fix build error #35

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Updating Databroker submodule and Fix build error #35

merged 1 commit into from
Nov 7, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Oct 31, 2024 •
edited
Loading

To solve build error on main. Updating submodule reference should not have impact, but on the other hand should not matter.

What I think was root cause:

  • proto files were generated before we installed requirement.txt, using a newer proto than in lock file
  • that gave problems in next step as grpcio was too old

@erikbosch erikbosch changed the title Updating Databroker submodule Updating Databroker submodule and Fix build error Oct 31, 2024
@erikbosch
Updating Databroker submodule
6133afd 
Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
@erikbosch erikbosch marked this pull request as ready for review November 1, 2024 08:51
lukasmittag
lukasmittag approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmittag lukasmittag merged commit e4f0a92 into eclipse-kuksa:main Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmittag lukasmittag lukasmittag approved these changes

@SebastianSchildt SebastianSchildt Awaiting requested review from SebastianSchildt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikbosch @lukasmittag