Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct metadata for debian packages #5340

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mattdibi
Copy link
Contributor

@mattdibi mattdibi commented Aug 29, 2024

Currently, in our .deb packages, we're not setting the metadata correctly.

Architecture

Reference: https://www.debian.org/doc/debian-policy/ch-controlfields.html#architecture

Depending on context and the control file used, the Architecture field can include the following sets of values:

  • A unique single word identifying a Debian machine architecture as described in Architecture specification strings.
  • An architecture wildcard identifying a set of Debian machine architectures, see Architecture wildcards. any matches all Debian machine architectures and is the most frequently used.
  • all, which indicates an architecture-independent package.
  • source, which indicates a source package.

We're currently using all but it's not correct since we have architecture dependent code. I updated the Architecture fields using the "Architecture specification strings" as per Debian documentation.

Description

Reference: https://www.debian.org/doc/debian-policy/ch-controlfields.html#description

In a source template control file or binary control file, the Description field contains a description of the binary package, consisting of two parts, the synopsis or the short description, and the long description. It is a multiline field with the following format:

Description: single line synopsis
extended description over several lines

I added the "single line synopsis" in this PR.

Filename

WIP

@mattdibi mattdibi changed the title fix: set correct architecture for debian packages fix: set correct metadata for debian packages Aug 29, 2024
Copy link
Contributor

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the Stale label Oct 29, 2024
@mattdibi
Copy link
Contributor Author

This pull request is stale because it has been open for 60 days with no activity.

shoo

@github-actions github-actions bot removed the Stale label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant