fix: Use dynamic policy for PositionProvider reference in PositionService #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
MMaiero
changed the title
mattdibi
requested review from
mattdibi
and removed request for
salvatore-coppola
mattdibi
approved these changes
Nov 12, 2024
|
Tested in combination with: #5544. Startup time with active cloud connection went from 140 seconds to 53 seconds |
MMaiero
pushed a commit
that referenced
this pull request
Nov 13, 2024
…vice [backport release-5.6.0] (#5545) fix: Use dynamic policy for PositionProvider reference in PositionService (#5529) fix: Use dynamic policy for PositonProvider reference in PositionService Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com> (cherry picked from commit 72a2834) Co-authored-by: nicolatimeus <nicola.timeus@eurotech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR. [e.g. Added
nullcheck onobjectto avoidNullPointerException]Changes the policy of the
PositionProviderreference in thePositionServicefrom static to dynamic.Having the policy set as static causes the PositionService and all services that depend on it with a static reference (e.g. the
CloudService) to be deactivated and reactivated whenever aPositionProvideris registered or unregistered, causing unnecessary service reactivations on startup and shutdown.The fact that the CloudService is reactivated may cause the pubblication of spurious lifecycle messages.
Also fixes possible NPE thrown by
getPosition(),getNmeaPosition()andisLocked()if called when the configured provider is not bound.