Add About file to LemMinX OSGi bundle. #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
|
@angelozerr this looks like something that can be merged without much risk |
|
@rgrunber as this will also end up in the uber artifact, I think it would be good to mention that other licenses here as well, this will become especially useful in the light of further embedding of dependencies like here: guava for example is Apache 2.0 licensed and the uber-jar does not make it clear what licenses apply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://www.eclipse.org/projects/handbook/#legaldoc-plugins-abouts .
The uber jar already contains one, but I suspect it is the one provided by LSP4J. At least for the non-uber jar, there should be an about file.