Make m2e.core.ui host of archetype-fragments and delete archetype.common #1494

HannesWell · 2023-07-30T22:07:26Z

The Plugin o.e.m2e.archetype.common is empty and only serves as host for the maven-archetype fragment-bundles. Since they are only used by m2e.core.ui, we can simply make that the host of those fragments and save one project in m2e.

@laeubi what do you think?

github-actions · 2023-07-30T22:11:49Z

Test Results

106 files ±0 106 suites ±0 11m 7s ⏱️ - 2m 43s
660 tests ±0 650 ✔️ +1 10 💤 ±0 0 ❌ - 1
660 runs ±0 649 ✔️ +1 11 💤 ±0 0 ❌ - 1

Results for commit f1380c6. ± Comparison against base commit 837d904.

♻️ This comment has been updated with latest results.

laeubi · 2023-07-31T04:45:35Z

I don't think this is really worth because it require special treatment of the m2.ui bundle.
If you think we really should save bundles, one can make the archtype common the host bundle (by adding an extra bnd mapping for it to the TP) and the other ones fragments of that bundle but be aware that this is actually a major change for the feature.

HannesWell · 2023-08-19T20:45:18Z

one can make the archtype common the host bundle (by adding an extra bnd mapping for it to the TP) and the other ones fragments of that bundle

Did that and also re-used the jdom2 bundle provided by maven-bnd Orbit, so that we don't have to define an own one.

but be aware that this is actually a major change for the feature.

I wouldn't consider this a braeking change in thise case since the bundles contained in this PDE are more internal and the same feature (in a functional sense is still provided). But I worked around this, simply by keep the generated bundle name as org.eclipse.m2e.archetype.common.

HannesWell · 2023-08-19T20:46:41Z

org.eclipse.m2e.feature/feature.xml

+         version="0.0.0"
+         fragment="true"
+         unpack="false"/>
+
+   <plugin
+         id="org.eclipse.m2e.archetype.catalog"
+         download-size="0"
+         install-size="0"
+         version="0.0.0"
+         fragment="true"
+         unpack="false"/>
+
+   <plugin
+         id="org.eclipse.m2e.archetype.descriptor"
+         download-size="0"
+         install-size="0"
+         version="0.0.0"
+         fragment="true"
+         unpack="false"/>
+
+   <plugin
+         id="org.eclipse.m2e.archetype.maven-artifact-transfer"
+         download-size="0"
+         install-size="0"
+         version="0.0.0"
+         fragment="true"
+         unpack="false"/>


@laeubi do you see any reason that speaks against including the archetype bundles in this feature?
I would prefer it over the p2.inf file since it is less magic.

The p2.inf ensures that all fragments are always installed together (especially for cases like tests).

The p2.inf ensures that all fragments are always installed together (especially for cases like tests).

This can also be achieved by corresponding Import-Packages and is less magic and even less to type.

No this can't work because a fragment is always optional, so a consumer would need to import a package from each fragment even if it is never used.

No this can't work because a fragment is always optional, so a consumer would need to import a package from each fragment even if it is never used.

That's right, a fragment is optional but m2e.core.ui already needs to import a package from each of the archetype artifacts (if one does not use require-bundle). The only import that would not be necessary from a class-loading/compiling point of view is the maven-transfer. But I think one not so necessary import is IMHO ok. And just to save that I wouldn't add/keep the p2.inf.

HannesWell · 2023-08-21T20:59:17Z

@laeubi this change is IMHO now ready, do you have any objects?

target-platform/target-platform.target

laeubi · 2023-08-22T04:11:45Z

target-platform/target-platform.target

+Bundle-Name:           M2Eclipse supplement fragment for ${mvnGroupId}:${mvnArtifactId}:${mvnVersion}
+version:               ${version_cleanup;${mvnVersion}}
+Bundle-SymbolicName:   org.eclipse.m2e.archetype.common
+Bundle-Version:        ${version}.1


this will result in a 3.2.1.1 version is this really desired?

Yes it is.
It is a (manual) qualifier bump so that those that use the snapshots don't miss the update.
When there is a new archetype version, it can be removed.

1 is really a bad qualifier, why not do like in maven-runtime and use

${version}01 what will result in 3.2.101

target-platform/target-platform.target

The Plugin o.e.m2e.archetype.common is empty and only serves as host for the maven-archetype fragment-bundles. Since they are only used by m2e.core.ui, we can simply make that the host of those fragments and save one project in m2e. In o.e.m2e.core.ui import all required packages plus those that are from fragments that are also needed for archetype.common to function properly, even if the package is not directly needed in m2e.core.ui.

The Plug-in org.eclipse.m2e.archetype.common is not a Fragment and the corresponding attribute was added erroneously. This was accidentally added in eclipse-m2e#1494 Reported in eclipse-m2e#1537

The Plug-in org.eclipse.m2e.archetype.common is not a Fragment and the corresponding attribute was added erroneously. This was accidentally added in #1494 Reported in #1537

HannesWell force-pushed the archetypeHost branch 3 times, most recently from 34b9695 to 2055eca Compare August 19, 2023 20:43

HannesWell commented Aug 19, 2023

View reviewed changes

HannesWell force-pushed the archetypeHost branch 4 times, most recently from 0a0f68f to 8d68f5f Compare August 20, 2023 16:54

HannesWell mentioned this pull request Aug 20, 2023

Add latest tm4e release (0.8) to m2e's TP directly #1516

Merged

HannesWell force-pushed the archetypeHost branch 3 times, most recently from ff657d7 to 23659cc Compare August 21, 2023 20:58

laeubi reviewed Aug 22, 2023

View reviewed changes

target-platform/target-platform.target Outdated Show resolved Hide resolved

laeubi reviewed Aug 22, 2023

View reviewed changes

target-platform/target-platform.target Outdated Show resolved Hide resolved

HannesWell force-pushed the archetypeHost branch 3 times, most recently from d870fbf to 0d82317 Compare August 22, 2023 08:01

HannesWell force-pushed the archetypeHost branch from 0d82317 to f1380c6 Compare August 22, 2023 08:12

HannesWell merged commit d2ec2f0 into eclipse-m2e:master Aug 22, 2023
4 of 5 checks passed

HannesWell deleted the archetypeHost branch August 22, 2023 22:17

HannesWell added this to the 2.4.0 milestone Aug 27, 2023

HannesWell mentioned this pull request Aug 28, 2023

M2E archetype has changed it structure eclipse-scout/scout.sdk#23

Closed

HannesWell mentioned this pull request Aug 31, 2023

Remove erroneous fragment attribute in m2e.feautre #1540

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make m2e.core.ui host of archetype-fragments and delete archetype.common #1494

Make m2e.core.ui host of archetype-fragments and delete archetype.common #1494

HannesWell commented Jul 30, 2023

github-actions bot commented Jul 30, 2023 •

edited

Loading

laeubi commented Jul 31, 2023

HannesWell commented Aug 19, 2023

HannesWell Aug 19, 2023

laeubi Aug 20, 2023 •

edited

Loading

HannesWell Aug 20, 2023

laeubi Aug 20, 2023

HannesWell Aug 20, 2023 •

edited

Loading

HannesWell commented Aug 21, 2023

laeubi Aug 22, 2023

HannesWell Aug 22, 2023

laeubi Aug 22, 2023

Make m2e.core.ui host of archetype-fragments and delete archetype.common #1494

Make m2e.core.ui host of archetype-fragments and delete archetype.common #1494

Conversation

HannesWell commented Jul 30, 2023

github-actions bot commented Jul 30, 2023 • edited Loading

Test Results

laeubi commented Jul 31, 2023

HannesWell commented Aug 19, 2023

HannesWell Aug 19, 2023

Choose a reason for hiding this comment

laeubi Aug 20, 2023 • edited Loading

Choose a reason for hiding this comment

HannesWell Aug 20, 2023

Choose a reason for hiding this comment

laeubi Aug 20, 2023

Choose a reason for hiding this comment

HannesWell Aug 20, 2023 • edited Loading

Choose a reason for hiding this comment

HannesWell commented Aug 21, 2023

laeubi Aug 22, 2023

Choose a reason for hiding this comment

HannesWell Aug 22, 2023

Choose a reason for hiding this comment

laeubi Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 30, 2023 •

edited

Loading

laeubi Aug 20, 2023 •

edited

Loading

HannesWell Aug 20, 2023 •

edited

Loading