Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed maven classpath container check to maven nature one #1818

Conversation

treilhes
Copy link
Contributor

Hello @HannesWell,
Follow up for #1672, simple change : maven classpath container check to maven nature one

Copy link

github-actions bot commented Aug 28, 2024

Test Results

  324 files  ±0    324 suites  ±0   29m 8s ⏱️ + 1m 27s
  673 tests ±0    652 ✅  - 1  18 💤 ±0  2 ❌ +1  1 🔥 ±0 
2 019 runs  ±0  1 962 ✅  - 1  54 💤 ±0  2 ❌ +1  1 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 93950c1. ± Comparison against base commit c8bcaaa.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Contributor

Thank you.
Please squash your changes into one commit with a message covering the change as a whole. Github's Sauash-and-merge button has undersided results.

@treilhes treilhes force-pushed the fastfix/surefire_plugins_arguments_to_launch_config_ff1 branch from eea3148 to 93950c1 Compare August 28, 2024 19:06
@treilhes
Copy link
Contributor Author

@HannesWell
Squash done

Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HannesWell HannesWell merged commit b128c37 into eclipse-m2e:master Aug 28, 2024
6 of 8 checks passed
@HannesWell HannesWell added this to the 2.6.2 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants