Skip to content

[#313] move MylynDocs org.eclipse.mylyn.wikitext.tasks.ui #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

BeckerFrank
Copy link
Contributor

[#313] move MylynDocs org.eclipse.mylyn.wikitext.tasks.ui Project to Mylyn as org.eclipse.mylyn.tasks.wikitext.ui

(actual commit was eclipse-mylyn/org.eclipse.mylyn.docs@61491d1)

@gnl42
Copy link
Contributor

gnl42 commented Nov 18, 2023

Could you add org.eclipse.mylyn.commons.core/.settings/{org.eclipse.jdt.core.prefs,org.eclipse.jdt.ui.prefs} to the .settings folder

@gnl42
Copy link
Contributor

gnl42 commented Nov 18, 2023

Did you copy/past the files or merge repositories?
I don't see any git history for the new files

@merks
Copy link
Contributor

merks commented Nov 18, 2023

I still get the sense that it would be in the long terms interest to merge the repos as was already done with all the separate repos....

@BeckerFrank
Copy link
Contributor Author

Could you add org.eclipse.mylyn.commons.core/.settings/{org.eclipse.jdt.core.prefs,org.eclipse.jdt.ui.prefs} to the .settings folder

I have copied the .settings folder from org.eclipse.mylyn.gitlab.core. This folder only contains the org.eclipse.jdt.core.prefs. So I have to create the org.eclipse.jdt.ui.prefs also in the gitlab projects.

@BeckerFrank
Copy link
Contributor Author

Did you copy/past the files or merge repositories? I don't see any git history for the new files

Yes because I only want to move one project.

@BeckerFrank
Copy link
Contributor Author

I still get the sense that it would be in the long terms interest to merge the repos as was already done with all the separate repos....

Yes, we can start a discussion with @akurtakov (the Mylyn Docs committer).

If we merge repositories, we should answer the following questions.

  • Is it ok that we have the same release dates?
  • Can we have a single Jenkins build
  • Can we set up a single configuration of .github workflows?
  • Do we still need two separate p2 update sites?
  • maybe some more ...

@akurtakov
Copy link
Contributor

Yes, we can start a discussion with @akurtakov (the Mylyn Docs committer).

If we merge repositories, we should answer the following questions.

* Is it ok that we have the same release dates?

Assuming Mylyn releases regularly, this sounds ok.

* Can we have a single Jenkins build

Yes, it's possible but one would have to work quite a bit to make it happen. IMHO if this doesn't happen there is no point in merging.

* Can we set up a single configuration of .github workflows?

I don't see an issue here.

* Do we still need two separate p2 update sites?

Single repo should be fine (considering the prereqs of releng being unified and regular releases)

* maybe some more ...

Wikitext is used a lot (could be even mostly) via Maven Central https://mvnrepository.com/artifact/org.eclipse.mylyn.wikitext - so the release process should keep the publishing to Maven Central working.

@gnl42
Copy link
Contributor

gnl42 commented Nov 19, 2023

Did you copy/past the files or merge repositories? I don't see any git history for the new files

Yes because I only want to move one project.

You can still just "merge" one folder/files. Something like: https://medium.com/@ayushya/move-directory-from-one-repository-to-another-preserving-git-history-d210fa049d4b

@gnl42
Copy link
Contributor

gnl42 commented Nov 19, 2023

Could you add org.eclipse.mylyn.commons.core/.settings/{org.eclipse.jdt.core.prefs,org.eclipse.jdt.ui.prefs} to the .settings folder

I have copied the .settings folder from org.eclipse.mylyn.gitlab.core. This folder only contains the org.eclipse.jdt.core.prefs. So I have to create the org.eclipse.jdt.ui.prefs also in the gitlab projects.

With #200 I made org.eclipse.mylyn.commons.core the "reference" project for formatting rules. Not an issue at the moment, but should make a note to run the synch script occasionally

@BeckerFrank
Copy link
Contributor Author

I think we should close this pull request because I star with integrating the whole mylyn docs repository with integrating Jenkins maven and GitHub.

@ruspl-afed
Copy link
Contributor

I pay tribute to your courage @BeckerFrank

@wimjongman
Copy link
Member

Where is a description of this task? It says #313, but that moves back to this PR. What is the plan, and why do we want this?

@wimjongman
Copy link
Member

wimjongman commented Nov 20, 2023

Sorry, I was confused. It turns out that Github now also shows PR's when searching in the issues section. There is eclipse-mylyn/org.eclipse.mylyn.docs#131 that explains it.

@BeckerFrank
Copy link
Contributor Author

I close this pull request because the work was done with #316

@BeckerFrank BeckerFrank deleted the MylynDocs-Add-WikitextUI branch November 23, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants