Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #99

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Update CONTRIBUTING.md #99

merged 1 commit into from
Jul 15, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Jul 13, 2024

Include a link to the Oomph setup.

Include a link to the Oomph setup.
@merks
Copy link
Contributor Author

merks commented Jul 13, 2024

@fipro78

This adds the link to the contribution guide.

@merks
Copy link
Contributor Author

merks commented Jul 13, 2024

Given this only changes a *.md file, the build failure seems not related. And this build passed:

#98

@fipro78
Copy link
Contributor

fipro78 commented Jul 13, 2024

@merks
Since the update of the target platform to a newer eclipse platform I see these test failures spawning sometimes. Looks like a concurrency issue that sometimes events are not fired when they should (at least in the test) and therefore the test fails. I have no idea why this happens since the update.

@merks
Copy link
Contributor Author

merks commented Jul 13, 2024

I see. That’s very annoying and disconcerting. One can’t be sure if it’s a test case problem or a real framework problem.

@fipro78
Copy link
Contributor

fipro78 commented Jul 14, 2024

Yes, I am still searching for the cause. Hard to find because locally the tests succeed most of the time.

@fipro78 fipro78 merged commit 787b760 into eclipse-nattable:master Jul 15, 2024
1 of 2 checks passed
@fipro78 fipro78 added this to the 2.5.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants