Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple execution of junit.runtime.tests and always clear workspace #1361

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Jul 30, 2024

Fixes #1360

Copy link

github-actions bot commented Jul 30, 2024

Test Results

   285 files  ±    0     285 suites  ±0   51m 49s ⏱️ + 5m 58s
 3 580 tests  -     1   3 504 ✅ +    1   76 💤 ± 0  0 ❌  - 1 
10 932 runs  +2 601  10 701 ✅ +2 579  231 💤 +24  0 ❌  - 1 

Results for commit 2ec27c4. ± Comparison against base commit 9a216f5.

This pull request removes 1 test.
org.eclipse.pde.junit.runtime.tests.JUnit5SuiteExecutionTest ‑ Unknown test

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the investigate-1360 branch 2 times, most recently from a5d4080 to 00d6177 Compare July 31, 2024 17:50
@HannesWell
Copy link
Member Author

Looks like JUnit5SuiteExecutionTest also called JUnitExecutionTest.setupProjects() but didn't have the CLEAR_WORKSPACE TestRule specified. Furthermore both the JUnit5SuiteExecutionTest and the JUnitExecutionTest were executed twice in verification builds because JUnitRuntimeTests suite defined in the package was not declared as testClass in the pom.xml (only referenced in the test.xml for I-Builds)

@HannesWell HannesWell changed the title Investigation of JUnit5SuiteExecutionTest test failure Prevent multiple execution of junit.runtime.tests and always clear workspace Jul 31, 2024
@HannesWell
Copy link
Member Author

Great all tests pass again now.
As expected, the number of test execution has been reduced but only because the duplicated execution of JUnitExecutionTest and JUnit5SuiteExecutionTest is now avoided. I verified that both are now executed exactly once.

@HannesWell HannesWell merged commit effe41d into eclipse-pde:master Jul 31, 2024
17 checks passed
@HannesWell HannesWell deleted the investigate-1360 branch July 31, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JUnit5SuiteExecutionTest fails with "Resource '/verification.tests.junit5' already exists." on Linux
1 participant