Remove unused DOMParserWrapper and strip down PDEXMLHelper #665
Conversation
I am not familiar with the code. Only did technical change. |
HannesWell
force-pushed
the
removeUnusedXML
branch
from
d734f26
to
7e04905
Compare
|
Does anybody know why there was a Nevertheless it should be checked if the differences are relevant. Does anybody know this already? |
HannesWell
force-pushed
the
removeUnusedXML
branch
2 times, most recently
from
46555e5
to
f7a26e6
Compare
HannesWell
force-pushed
the
removeUnusedXML
branch
from
f7a26e6
to
2044151
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @SuppressWarnings("restriction") | ||
| SAXParser parser = org.eclipse.core.internal.runtime.XmlProcessorFactory | ||
| .createSAXParserWithErrorOnDOCTYPE(); | ||
| parser.parse(stream, handler); |
Check failure
Code scanning / CodeQL
Resolving XML external entity in user-controlled data Critical
There was a problem hiding this comment.
interesting: CodeQL added a false positive marker here
There was a problem hiding this comment.
Yes, I assume it does not understand the method that creates the factory.
ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/util/SchemaUtil.java
Dismissed
Show dismissed
Hide dismissed
- Inline SAXParserWrapper - Remove unused code from PDEXMLHelper - Use XMLProcessorFactory from eclipse.platform in favor of a own one
HannesWell
force-pushed
the
removeUnusedXML
branch
from
2044151
to
f56c9d7
Compare
HannesWell
force-pushed
the
removeUnusedXML
branch
from
f56c9d7
to
b568b0d
Compare
| @@ -84,10 +83,11 @@ public class XmlReferenceDescriptorWriter { | |||
| * to write the reports to | |||
| * @param debug if debugging infos should be written out to the console | |||
| */ | |||
| @SuppressWarnings("restriction") | |||
There was a problem hiding this comment.
using a local variable could move the suppress to the actual line of code.
There was a problem hiding this comment.
Unfortunately the parser field is also used below and since this method is relatively small in scope I skipped the extra variable in this case for simpler code.
|
looks like a lot of work. thanks. |
@jukzi you just worked in the area of XML processing recently, do you know any use-case of the to be removed classes?