Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup: Java 16 instanceof pattern matching #707

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

alshamams
Copy link
Contributor

@alshamams alshamams commented Aug 11, 2023

The commit tries to implement a code cleanup in pattern matching using instanceof operator according to Java 16 guidelines, making the code more concise.
The change has been applied in org.eclipse.pde.api.tools project.

Kindly review @akurtakov @iloveeclipse @vik-chand @gireeshpunathil and do let me know in case of any edits.

@github-actions
Copy link

Test Results

     246 files  ±0       246 suites  ±0   1h 4m 35s ⏱️ + 10m 34s
  3 298 tests ±0    3 273 ✔️ +1  24 💤 ±0  0 ±0  1 🔥  - 1 
10 191 runs  ±0  10 118 ✔️ +1  72 💤 ±0  0 ±0  1 🔥  - 1 

For more details on these errors, see this check.

Results for commit c4d6537. ± Comparison against base commit d7228a1.

@akurtakov akurtakov merged commit 8435fdd into eclipse-pde:master Aug 12, 2023
12 of 14 checks passed
@akurtakov
Copy link
Member

Looks good. Thanks for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants