Show warnings/errors from the BND build #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 246 files ±0 246 suites ±0 1h 8m 11s ⏱️ - 7m 5s For more details on these failures, see this check. Results for commit f4823ba. ± Comparison against base commit c71d0c1. ♻️ This comment has been updated with latest results. |
HannesWell
requested changes
Aug 16, 2023
ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndBuilder.java
Outdated
Show resolved
Hide resolved
ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndBuilder.java
Outdated
Show resolved
Hide resolved
ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndErrorReporter.java
Show resolved
Hide resolved
laeubi
force-pushed
the
issue_699
branch
2 times, most recently
from
a43bbb8
to
ff190a5
Compare
HannesWell
approved these changes
Aug 16, 2023
Currently if one has an error in the pde.bnd file there is no feedback for the user about the problem. This adds a validator that reads the errors/warning and display them to the user as error markers mapping the error to a line number if possible. Fix eclipse-pde#699
|
@laeubi I have slightly stream-lined the code in two places and force pushed it to trigger a re-build (the previous one seems to had some outages). Since M3 is now available I plan to merge this as soon as the build succeeds so we have as much time as possible to test this with I-builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one has an error in the pde.bnd file there is no feedback for the user about the problem.
This adds a validator that reads the errors/warning and display them to the user as error markers mapping the error to a line number if possible.
Fix #699
@HannesWell @vik-chand I'd like to include this into M3 as it is otherwise very hard for users to notice that something is wrong (beside from getting annoyed that 'something' seems not working)