4.33 I-Build: I20240724-1800 - BUILD FAILED

[MohananRahul]

See : https://ci.eclipse.org/releng/job/Builds/job/I-build-4.33/80/console

4.377Z] [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:4.0.8:compile (default-compile) on project org.eclipse.pde.api.tools.annotations: Fatal error compiling: target level should be in '1.8','9'...'22' (or '8.0'..'22.0'): 1.6 -> [Help 1]
[2024-07-24T22:05:54.377Z] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:4.0.8:compile (default-compile) on project org.eclipse.pde.api.tools.annotations: Fatal error compiling
[2024-07-24T22:05:54.377Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:333)
[2024-07-24T22:05:54.377Z] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
[2024-07-24T22:05:54.377Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
[2024-07-24T22:05:54.377Z] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
[2024-07-24T22:05:54.378Z] at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
[2024-07-24T22:05:54.378Z] at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
[2024-07-24T22:05:54.378Z] at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)

[HannesWell]

@iloveeclipse I'm currently checking/fixing all PDE plugins.

[iloveeclipse]

The build fails because we've changed compiler in eclipse-jdt/eclipse.jdt.core#2551 and expect only Java 1.8+ as target.

My fault no to check if SDK is ready for that, I've assumed we are at
1.8 already, which is not the case 🙁

I plan to work on that soon, in case someone wants to help, bundles
should require JavaSE-1.8 as minimum EE and org.eclipse.jdt.core.prefs
settings should be at least 1.8 level:

org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8
org.eclipse.jdt.core.compiler.compliance=1.8
org.eclipse.jdt.core.compiler.source=1.8 

[HannesWell]

PR for PDE is up:

• Move api.tools.annotations to Java-1.8 eclipse-pde/eclipse.pde#1349

Btw. I would like to make everyone whose updating the required Java version of a Plug-in project aware of the new Modify button in the PDE MANIFEST.MF-Editor:

• Add a new "Modify" button to Execution Environment section eclipse-pde/eclipse.pde#1285

Besides updating the BREE it automatically adjusts the JRE_CONTAINER in the .classpath and the JDT compiler settings accordingly.

[laeubi]

would like to make everyone whose updating the required Java version of a Plug-in project aware of the new Modify button in the PDE MANIFEST.MF-Editor

Seems this feature got in just-in-time 👍

[HannesWell]

PR for PDE is up:

- https://github.com/eclipse-pde/eclipse.pde/pull/1349

This one is submitted.

@iloveeclipse I have to leave now, can you have a look at the other parts?

I have also triggered a master build for eclipse.platform.releng.aggregator:

• https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/job/master/2483/

Since this fetches the latest master of each sub-module, it can be considered as an 'I-build light'.

[iloveeclipse]

I have to leave now, can you have a look at the other parts?

Sure, I'm looking into.

[iloveeclipse]

Build https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/job/master/2483/console was successful, even without eclipse-jdt/eclipse.jdt.core.binaries#13 merged (probably because there is nothing to compile).

I'm pretty sure there could be test failures, but let address them once we see them, so I will trigger SDK build now.

[iloveeclipse]

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.33/81/ is triggered.

[merks]

As usual @iloveeclipse thanks for your diligence!! And @HannesWell of course too!!

[iloveeclipse]

https://download.eclipse.org/eclipse/downloads/drops4/I20240725-0200 is there.
Waiting to see how many test fails we will see...

[iloveeclipse]

Mac build shows only 1168 fails :-)
Majority (968) is for pde.api tools.
Will look into after lunch...

[laeubi]

Majority (968) is for pde.api tools.

They almost all complain about

Should not be a JDT error: Compiling for Java version '1.5' is no longer supported. Minimal supported version is '1.8'

[iloveeclipse]

Let's close this one, SDK builds and majority of failures are fixed.
Thanks Hannes for PDE fixes.
I will address remaining issues in JDT UI, it took longer as I've expected, as they have to be analyzed one by one.