-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move api.tools.annotations to Java-1.8 #1349
Conversation
Targeting Java version below 1.8 is not supported anymore by the ECJ.
There are also many test bundles that have a BREE below 1.8. Lets see if they have to be bumped too. |
For reference: The target was lowered in #913 to allow using these annotations (that are usually provided by the Eclipse runtime used for development IIRC) in applications targeting older java (and Eclipse releases). |
If the projects are compiled in Eclipse during tests, yes. |
Yes. But I'm reluctant to just bump everything because I don't know what is verified in tests as well. |
As far as I have understand the compiler will simply no longer support these so the build will fail anyways unless we configure an older compiler in the build. |
It depends. Maybe these test-projects don't contain sources, I haven't checked it yet. But Jenkins and the GH workflow for Windows already succeeded, GH-workflow for Linux has one test-failure but that looks unrelated. |
@HannesWell as long as no new compiler is deployed (and the aggregator pom updated) still the old compiler is used in verification builds. |
Yes that could definitively reveal more older targets. But it looks like there are still test resources that have no sources, too. E.g. there are numerous resources for the api.tools tests that all have a |
Part of eclipse-platform/eclipse.platform.releng.aggregator#2197
Caused by eclipse-jdt/eclipse.jdt.core#2551