Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move api.tools.annotations to Java-1.8 #1349

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

HannesWell
Copy link
Member

Targeting Java version below 1.8 is not supported anymore by the ECJ.
@HannesWell
Copy link
Member Author

There are also many test bundles that have a BREE below 1.8. Lets see if they have to be bumped too.

@HannesWell
Copy link
Member Author

For reference: The target was lowered in #913 to allow using these annotations (that are usually provided by the Eclipse runtime used for development IIRC) in applications targeting older java (and Eclipse releases).

@iloveeclipse
Copy link
Member

There are also many test bundles that have a BREE below 1.8. Lets see if they have to be bumped too.

If the projects are compiled in Eclipse during tests, yes.

@HannesWell
Copy link
Member Author

There are also many test bundles that have a BREE below 1.8. Lets see if they have to be bumped too.

If the projects are compiled in Eclipse during tests, yes.

Yes. But I'm reluctant to just bump everything because I don't know what is verified in tests as well.

@laeubi
Copy link
Contributor

laeubi commented Jul 25, 2024

As far as I have understand the compiler will simply no longer support these so the build will fail anyways unless we configure an older compiler in the build.

@HannesWell
Copy link
Member Author

As far as I have understand the compiler will simply no longer support these so the build will fail anyways unless we configure an older compiler in the build.

It depends. Maybe these test-projects don't contain sources, I haven't checked it yet.
But my goal is to make the build at at least compile again, test-failures can still be fixed later.
I don't have that much time this morning to do a deep check what's necessary.

But Jenkins and the GH workflow for Windows already succeeded, GH-workflow for Linux has one test-failure but that looks unrelated.
That's sufficient to submit it now even tough the Mac-workflow is still running.

@HannesWell HannesWell merged commit 819e5b0 into eclipse-pde:master Jul 25, 2024
15 of 16 checks passed
@HannesWell HannesWell deleted the target-java-1.8 branch July 25, 2024 05:36
@laeubi
Copy link
Contributor

laeubi commented Jul 25, 2024

@HannesWell as long as no new compiler is deployed (and the aggregator pom updated) still the old compiler is used in verification builds.

@HannesWell
Copy link
Member Author

@HannesWell as long as no new compiler is deployed (and the aggregator pom updated) still the old compiler is used in verification builds.

Yes that could definitively reveal more older targets. But it looks like there are still test resources that have no sources, too. E.g. there are numerous resources for the api.tools tests that all have a J2SE-1.4 BREE and only compares an .api_description file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants