Migrate 5 OldSchoolEffect examples to GraphicsExample#3199
Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Migrate 5 OldSchoolEffect examples to GraphicsExample#3199vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Migrate the following effects from SWT-OldSchoolEffect to AnimatedGraphicsTab implementations in the GraphicsExample: - BurningSea → BurningSeaTab - Coppers → CopperBarsTab - Fire → FireTab - Moire → MoireTab - RasterBars → RasterBarsTab Each effect follows the established migration pattern: - Extends AnimatedGraphicsTab with category 'Misc' - Proper Image disposal in dispose() and before recreation - No Color disposal (modern SWT) - Localized strings in examples_graphics.properties - $NON-NLS-1$ markers on all resource string keys - EPL-2.0 header with original author credits Contributes to eclipse-platform#3189 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vogella
force-pushed
the
migrate-5-oldschool-effects
branch
from
fa5dcf4 to
ba45223
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates 5 pure algorithmic effects from SWT-OldSchoolEffect to the SWT GraphicsExample framework:
burningsea/BurningSea.javaBurningSeaTabcopper/Coppers.javaCopperBarsTabfire/Fire.javaFireTabmoire/Moire.javaMoireTabrasterbars/RasterBars.javaRasterBarsTabMigration Checklist
new Color(r, g, b)constructordispose()and before recreation$NON-NLS-1$markers on resource string keysexamples_graphics.propertiesBuild Verification
✅ BUILD SUCCESS
Contributes to #3189