Disable "Select All" button for empty input

Just like other buttons on this dialog. Fixes #1046
eclipse-platform · Aug 21, 2023 · 01c5b67 · 01c5b67
1 parent 4d2db98
commit 01c5b67
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/.../org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java b/.../org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceDialog.java
@@ -1693,6 +1693,7 @@ private void updateButtonState(boolean disableReplace) {
 			fWholeWordCheckBox.setEnabled(isWord(str) && !isRegExSearchAvailableAndChecked());
 
 			fFindNextButton.setEnabled(enable && findString);
+			fSelectAllButton.setEnabled(enable && findString && fTarget instanceof IFindReplaceTargetExtension4);
 			fReplaceSelectionButton.setEnabled(!disableReplace && enable && isEditable() && selection && (!fNeedsInitialFindBeforeReplace || !isRegExSearchAvailableAndChecked()));
 			fReplaceFindButton.setEnabled(!disableReplace && enable && isEditable() && findString && selection && (!fNeedsInitialFindBeforeReplace || !isRegExSearchAvailableAndChecked()));
 			fReplaceAllButton.setEnabled(enable && isEditable() && findString);
@@ -1834,12 +1835,8 @@ public void updateTarget(IFindReplaceTarget target, boolean isTargetEditable, bo
 				fGiveFocusToFindField= true;
 			}
 			initIncrementalBaseLocation();
-			updateButtonState();
-		}
-
-		if (okToUse(fSelectAllButton)) {
-			fSelectAllButton.setEnabled(fTarget instanceof IFindReplaceTargetExtension4);
 		}
+		updateButtonState();
 
 		setContentAssistsEnablement(isRegExSearchAvailableAndChecked());
 	}