Find/replace overlay: reassign to changed shell asynchronously #1945 #2096
Conversation
…e-platform#1945 The synchronous execution of reassigning the FindReplaceOverlay to a shell sporadically makes the application hang on Linux. This makes the execution asynchronous and avoid repeated executions of the reassignment. Contributes to eclipse-platform#1945
| setParentShell(targetPart.getSite().getShell()); | ||
| open(); | ||
| targetPart.setFocus(); | ||
| getShell().getDisplay().asyncExec(() -> { |
There was a problem hiding this comment.
This was the code leading to a bad bug on windows #1946 (comment)
The difference with the if being inside of the asyncexec block might be enough to not have the overlay be called multiple times, but somehow I doubt we really want to always create a new asynchronous job every time some movement was made
There was a problem hiding this comment.
I am not sure whether I get your points correctly.
The bug we had before was a flickering because the close/open combination was executed multiple times. This is properly prevented by re-checking the necessity for doing this close/open within the asynchronous execution block. On Windows, I looks fine:
but somehow I doubt we really want to always create a new asynchronous job every time some movement was made
Why do you assume that the execution is done "very time some movement was made"? The asynchronous execution is only initiated when the target of an open find/replace overlay is moved to another shell, which is a rather seldom user interaction (the condition is checked inside and outside of the execution block). I have debugged the behavior again and found that in this scenario the asynchronous execution is spawned either one or two times, such that at most one execution is "unecessary" (i.e., doing nothing as the condition evaluates to false) on every occurence of that scenario. I find this acceptable compared to some more complex tracking if whether the asynchronous execution was already initiated to avoid doing it a second time. What do you think, @Wittmaxi?
There was a problem hiding this comment.
I missed the outer if-clause, sorry! Thank you for clearing this up, I am in favor of merging this PR now.
The synchronous execution of reassigning the FindReplaceOverlay to a shell sporadically makes the application hang on Linux. This makes the execution asynchronous and avoid repeated executions of the reassignment.
Contributes to #1945
Follow-up to #1946