improve RegistrationMacOsX performance #2245

[jukzi]

Pattern matching with String.split("-{80}\n") is quiet expensive especially if the string contains more then 80 dashes in a row.

#2245

[github-actions]

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 30m 47s ⏱️ - 1m 40s
 7 697 tests ±0   7 469 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 252 runs  ±0  23 503 ✅ +1  749 💤 ±0  0 ❌  - 1 

Results for commit 4c67a49. ± Comparison against base commit 52470ac.

♻️ This comment has been updated with latest results.

[sratz]

Change looks good in principle.

However, there are exactly 80 dashes in that output, not more than 80.

Are you sure this will actually boost performance?

[jukzi]

Are you sure this will actually boost performance?

I dont't have mac to test it locally. It's just that this split was logged so often that it can be seen as hotspot and local generic tests show that the alternative regex is faster, also reusing the splitted result may help

[sratz]

Ok, then let's merge this and see if it helps 👍

[BeckerWdf]

Are you sure this will actually boost performance?

I don't have mac to test it locally. It's just that this split was logged so often that it can be seen as hotspot and local generic tests show that the alternative regex is faster, also reusing the splitted result may help

There are JUnit tests that have "real-life" console outputs. See: TestUnitRegistrationMacOsX. These should be runnable on all OSes. Can you provide numbers how much faster they run?

[BeckerWdf]

Thanks for taking care of performance.