Remove redundant flag check from ThemeEngine #2273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 210 files + 1 210 1 210 suites +1 210 1h 15m 2s ⏱️ + 1h 15m 2s Results for commit d27b0c5. ± Comparison against base commit c7da703. ♻️ This comment has been updated with latest results. |
Phillipus
force-pushed
the
theme-check
branch
3 times, most recently
from
6d655d0
to
53391f3
Compare
If the boolean "flag" is set to false the last conditional check will never be true so return early. The theme will have been set anyway.
Phillipus
force-pushed
the
theme-check
branch
from
53391f3
to
d27b0c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the boolean "flag" is set to false the last conditional check will never be true so return early. The theme will have been set anyway.