Various minor improvements for E4 EMF Xpath #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2024
Test Results 1 815 files 1 815 suites 1h 40m 10s ⏱️ For more details on these failures, see this check. Results for commit b9fe844. ♻️ This comment has been updated with latest results. |
HannesWell
force-pushed
the
improve-xpath
branch
from
bd72a0a
to
f8b4a24
Compare
HannesWell
commented
Sep 18, 2024
| @@ -42,19 +46,35 @@ public interface XPathContext { | |||
| * required type | |||
| * @return Object found | |||
| */ | |||
| Object getValue(String xpath, Class<?> requiredType); | |||
| <T> T getValue(String xpath, Class<T> requiredType); | |||
There was a problem hiding this comment.
Since the method signature is the same after generic erasure this is a binary and source compatible change.
But as far as I can tell, this method and its overload is not used within the SDK at all, besides tests.
|
If there are no unresolved remarks I plan to submit this tomorrow (European) evening. |
HannesWell
force-pushed
the
improve-xpath
branch
3 times, most recently
from
367b81b
to
4950874
Compare
instead of requiring the bundle 'org.apache.commons.jxpath'. This allows interested parties to supply alternative providers than the old and problematic 'org.apache.commons.jxpath'. Helps for eclipse-platform#423
HannesWell
force-pushed
the
improve-xpath
branch
from
4950874
to
b9fe844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three commits with minor improvements of the E4 EMF Xpath bundle:
as suggested in Remove dependencies on org.apache.commons.jxpath #423 (comment)
XPathContext.stream()and strengthen type of getValue(String, Class)The new method is for example useful in:
https://github.com/eclipse-pde/eclipse.pde/blob/ba11267159a1f5eed242af8f18dadc299f763637/e4tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/StringModelFragment.java#L587-L600