Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Close mode" frame in editor preference #2298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

praveen-skp
Copy link
Contributor

Issue: #2297

This pull request adds a "Close mode" frame in the editor preference to make the "Close editors automatically" and "Number of opened editors before closing" grouping clear.

@praveen-skp
Copy link
Contributor Author

Close mode

The new UI with "Close mode" grouping

@laeubi
Copy link
Contributor

laeubi commented Sep 19, 2024

Close mode as a group name reads a bit strange here, I would expect then having different modes to select but the configuration do not really offer that.

My suggestion would be to merge both settings into one line instead of grouping them e.g.

[ ] Close oldest if there are more than _____ editors open

Copy link
Contributor

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 36m 33s ⏱️ - 6m 18s
 7 699 tests ±0   7 470 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 258 runs  ±0  23 510 ✅  - 1  747 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit c3d99f0. ± Comparison against base commit 88b1d36.

@BeckerWdf
Copy link
Contributor

Close mode as a group name reads a bit strange here

What about "Closing behaviour"?

@BeckerWdf
Copy link
Contributor

My suggestion would be to merge both settings into one line instead of grouping them

This is also a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants