Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup css files #2301

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

BeckerWdf
Copy link
Contributor

  • We should not mix tabs and spaces as they make it harder to read code reviews
  • color valus don't need to be put into single quotes like color: '#ffffff' but should be color: #ffffff. By doing this the Generic Code Editor in Eclipse does correctly show the color inline with a code mining in the editor.

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 34m 13s ⏱️ + 4m 26s
 7 699 tests ±0   7 471 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 258 runs  ±0  23 511 ✅ +1  747 💤 ±0  0 ❌  - 1 

Results for commit 0f92418. ± Comparison against base commit 95cf53a.

♻️ This comment has been updated with latest results.

@BeckerWdf BeckerWdf self-assigned this Sep 20, 2024
@BeckerWdf BeckerWdf added this to the 4.34 M1 milestone Sep 20, 2024
@BeckerWdf BeckerWdf merged commit 57d846a into eclipse-platform:master Sep 24, 2024
13 of 16 checks passed
@BeckerWdf BeckerWdf deleted the cleanup_css_files branch September 24, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant