Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not run link handler registration in test execution #2306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Not run link handler registration in test execution #2306

wants to merge 1 commit into from

Conversation

BeckerWdf
Copy link
Contributor

No description provided.

@BeckerWdf
Copy link
Contributor Author

This PR depends on #2302

@BeckerWdf BeckerWdf mentioned this pull request Sep 20, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 40m 48s ⏱️ + 4m 15s
 7 699 tests ±0   7 470 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 258 runs  ±0  23 510 ✅  - 1  747 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit f9ba59b. ± Comparison against base commit 0986115.

♻️ This comment has been updated with latest results.

@BeckerWdf
Don't run the automatic registration during test execution
f9ba59b 
If the IDE is running because we are executing automated tests it
doesn't make sense to run this registration job.

Fixes : eclipse-platform#2245
@BeckerWdf BeckerWdf force-pushed the not_run_link_handler_registration_in_test_execution branch from 6b86521 to f9ba59b Compare September 24, 2024 07:57
@BeckerWdf BeckerWdf self-assigned this Sep 24, 2024
@BeckerWdf BeckerWdf added this to the 4.34 M1 milestone Sep 24, 2024
@BeckerWdf
Copy link
Contributor Author

@jukzi: Are the log entries in the test execution now gone for this PR?

@jukzi
Copy link
Contributor

jukzi commented Sep 24, 2024

@jukzi: Are the log entries in the test execution now gone for this PR?

i am not sure what you asking.
https://download.eclipse.org/eclipse/downloads/drops4/I20240923-1800/testresults/ep434I-unit-mac64-java17_macosx.cocoa.x86_64_17/org.eclipse.debug.tests.AutomatedSuite.txt still shows thousends.

java.lang.RuntimeException: Some job is still running or waiting to run: 
'AutoRegisterSchemeHandlersJob(19)'/org.eclipse.urischeme.AutoRegisterSchemeHandlersJob:RUNNING

but its only in the i-build not tested for every PR

@BeckerWdf
Copy link
Contributor Author

but its only in the i-build not tested for every PR

I thought it's also visible in PR-builds. So we have to merge this and have a look into the next i-build

BeckerWdf
BeckerWdf commented Sep 24, 2024
View reviewed changes
...rg.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/JUnitTestUtil.java
String application = envInfo.getProperty("eclipse.application"); //$NON-NLS-1$
result.set(application != null && Set.of( //
// see org.eclipse.pde.internal.launching.IPDEConstants
"org.eclipse.pde.junit.runtime.nonuithreadtestapplication", // //$NON-NLS-1$
Copy link
Contributor Author

@BeckerWdf BeckerWdf Sep 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sratz: from the i-build's log
https://download.eclipse.org/eclipse/downloads/drops4/I20240923-1800/testresults/ep434I-unit-mac64-java17_macosx.cocoa.x86_64_17/org.eclipse.debug.tests.AutomatedSuite.txt
i see
Framework arguments: -application org.eclipse.test.uitestapplication formatter=...
So it looks like org.eclipse.test.uitestapplication is used. Is it missing in this list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sratz sratz Awaiting requested review from sratz

Assignees

@BeckerWdf BeckerWdf

Labels
None yet
Projects
None yet
Milestone
4.34 M1
Development

Successfully merging this pull request may close these issues.
2 participants
@BeckerWdf @jukzi