Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindNextAction: synchronize History with FindReplaceOverlay and Dialog #2308

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

FindNextAction: synchronize History with FindReplaceOverlay and Dialog #2308

wants to merge 1 commit into from

Conversation

Wittmaxi
Copy link
Contributor

The history of the FindNextAction is now synchronized with the search history of either the FindReplaceOverlay or of the FindReplaceDialog (whichever is active currently).

fixes #2285

caveat: 15 entries of search history are lost after this PR

@Wittmaxi
FindNextAction: synchronize History with FindReplaceOverlay and Dialog
7e538c5 
The history of the FindNextAction is now synchronized with the search
history of either the FindReplaceOverlay or of the FindReplaceDialog
(whichever is active currently).

fixes eclipse-platform#2285
@github-actions GitHub Actions
Copy link
Contributor

Test Results

 1 210 files  ±0   1 210 suites  ±0   1h 9m 4s ⏱️ - 1m 4s
 7 699 tests ±0   7 468 ✅ +3  231 💤  - 2  0 ❌  - 1 
16 172 runs  ±0  15 659 ✅ +2  513 💤  - 1  0 ❌  - 1 

Results for commit 7e538c5. ± Comparison against base commit 8df2017.

This pull request skips 3 and un-skips 5 tests. 
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

@Wittmaxi Wittmaxi marked this pull request as draft October 15, 2024 11:01
@Wittmaxi Wittmaxi mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoKlare HeikoKlare Awaiting requested review from HeikoKlare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Find/Replace] 'Find Next' (Ctrl+K) command broken with the overlay
1 participant
@Wittmaxi