Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mw find next action use find replace logic #2309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Wittmaxi
Copy link
Contributor

Instead of re-implementing it's own logic, the FindNextAction now reuses
the FindReplaceLogic for it's backend.

The history of the FindNextAction is now synchronized with the search
history of either the FindReplaceOverlay or of the FindReplaceDialog
(whichever is active currently).

fixes eclipse-platform#2285
Instead of re-implementing it's own logic, the FindNextAction now reuses
the FindReplaceLogic for it's backend.
Copy link
Contributor

Test Results

  605 files   -   605    605 suites   - 605   29m 42s ⏱️ - 40m 26s
7 699 tests ±    0  7 465 ✅ ±    0  234 💤 +  1  0 ❌  - 1 
8 086 runs   - 8 086  7 852 ✅  - 7 805  234 💤  - 280  0 ❌  - 1 

Results for commit 6f3238c. ± Comparison against base commit 8df2017.

This pull request skips 1 test.
org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest ‑ testCompleteActivationChar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant